Hrm, looks like I forgot to run the tests. Oooops. Will fix and squash.

So I updated this to fix the tests ... but I'm looking for some guidance here. What I realized is that Ember.ArrayController included Ember.SortableMixin by default. So I followed Ember.ArrayController's lead and made the deprecation conditional based on if the controller was auto generated. But if a user just defined a plain ole Ember.ArrayController they will get the SortableMixin deprecation warning.

I couldn't find a clear path to only throw the warning if they had explicitly included Ember.SortableMixin or tried to utilize it on an Ember.ArrayController where it was already defined.

Perhaps one solution is to just make the deprecation warning better to notify a user that it is part of the ArrayController and if they're not using it, to ignore it. Thoughts?

Bump. I know there maybe some strings attached to this one, but myself and at least one other person were tripped up by this.

but I'm looking for some guidance here. What I realized is that Ember.ArrayController included
Ember.SortableMixin by default. So I followed Ember.ArrayController's lead and made the
deprecation conditional based on if the controller was auto generated. But if a user just defined a
plain ole Ember.ArrayController they will get the SortableMixin deprecation warning.

I couldn't find a clear path to only throw the warning if they had explicitly included
Ember.SortableMixin or tried to utilize it on an Ember.ArrayController where it was already defined.

Perhaps one solution is to just make the deprecation warning better to notify a user that it is part of
the ArrayController and if they're not using it, to ignore it. Thoughts?

My thought is if the user explicitly defines an ArrayController, it is probably okay to throw multiple deprecation warnings. Ember 1.13 has so much deprecation spew, what's a little more?

Thanks @workmanw !

You're welcome @rwjblue! I'll follow this up with a PR to the website.